[cpu][bench] Add CPU paged attention benchmarks#31720
Merged
bigPYJ1151 merged 2 commits intovllm-project:mainfrom Jan 6, 2026
Merged
[cpu][bench] Add CPU paged attention benchmarks#31720bigPYJ1151 merged 2 commits intovllm-project:mainfrom
bigPYJ1151 merged 2 commits intovllm-project:mainfrom
Conversation
Contributor
Author
|
@bigPYJ1151 could you please review? |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a benchmark script for CPU paged attention, which is a valuable addition for performance testing and optimization. The script is well-structured and provides a good range of configurable parameters. My review focuses on improving the robustness of the main benchmark function to prevent potential runtime errors if it's used in different contexts.
Fixes: vllm-project#30374 Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
fadara01
force-pushed
the
cpu_attn_benchmark
branch
from
b025d3d to
e12096e
Compare
1 task
github-actions
bot
added
the
ready
LucasWilkinson
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Jan 6, 2026
Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Jan 9, 2026
Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add CPU paged attention benchmarks
Fixes: #30374
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.